Don't self-test ECJPAKE ALT implementations against known entropy #4007
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gabor-mezei-arm
added
Community
needs-review
gabor-mezei-arm
added
the
component-crypto
chris-jones-arm
previously approved these changes
Jan 19, 2021
chris-jones-arm
added
needs-backports
ronald-cron-arm
requested changes
Jan 21, 2021
| @@ -1059,6 +1063,7 @@ int mbedtls_ecjpake_self_test( int verbose ) | |||
| if( verbose != 0 ) | |||
| mbedtls_printf( "passed\n" ); | |||
|
|
|||
| #if !defined(MBEDTLS_ECJPAKE_ALT) | |||
There was a problem hiding this comment.
Please add a comment explaining why those tests are not relevant in the case of an alternative implementation of ECJPAKE.
| @@ -820,6 +820,8 @@ static const unsigned char ecjpake_test_password[] = { | |||
| 0x65, 0x73, 0x74 | |||
There was a problem hiding this comment.
Commit message: the commit message is too long and not rendered properly by GitHub.
These implementations don't necessarily consume entropy the same way the mbed TLS internal software implementation does, and the 'reference handshake' test vectors can thus not be applied to an ALT implementation. Signed-off-by: Steven Cooreman <steven.cooreman@silabs.com>
stevew817
force-pushed
the
feature/alt_implementation_is_not_deterministic
branch
from
39860e6 to
64f2773
Compare
ronald-cron-arm
approved these changes
Jan 22, 2021
chris-jones-arm
approved these changes
Jan 22, 2021
There was a problem hiding this comment.
Just needs a backport as previously mentioned and then this is good to merge.
chris-jones-arm
removed
the
needs-reviewer
|
@chris-jones-arm backport available in #4057. |
chris-jones-arm
added
approved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
These implementations don't necessarily consume entropy the same way the mbed TLS internal software implementation does, and the 'reference handshake' test vectors can thus not be applied to an ALT implementation.
Status
READY
Requires Backporting
NO
Migrations
NO